Consensus: fix the quorum size #142
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 3 commits
March 6, 2019 11:39
The pBFT consensus has a fault tolerance of n = 3f + 1; the quorum size should be the ceil of n * 2 / 3.
orogvany
approved these changes
Mar 6, 2019
| @@ -503,7 +502,7 @@ protected void onNewView(Proof p) { | |||
| logger.trace("On new_view: {}", p); | |||
|
|
|||
| if (p.getHeight() == height // at same height | |||
| && p.getView() == view + 1 && state != State.COMMIT && state != State.FINALIZE) {// larger view | |||
| && p.getView() > view && state != State.COMMIT && state != State.FINALIZE) {// larger view | |||
There was a problem hiding this comment.
The problem here was one validator proposing a view greater than current view with their validator was being taken over anothoher more valid block with lower view. I think some protection here is needed. But I have not personally tested through the logic, just saw testnet attacked in this way
There was a problem hiding this comment.
I believe the check logic is here
Going to add some tests for it.
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
qneeds to be ceil of the2 / 3 * n. Take the syncing for example, we're picking a target height such that at leastqnumber of nodes have reached that height;