Align the block gas limit with the transaction size limit #213
Conversation
|
Now the problem is that this would break compatibility with the testnet. |
| protected Amount minTransactionFee = MILLI_SEM.of(5); | ||
| protected Amount minDelegateBurnAmount = SEM.of(1000); | ||
| protected long nonVMTransactionGasCost = 21_000L; | ||
| protected long nonVMTransactionGasCost = 5_000L; |
There was a problem hiding this comment.
This should prob still be 21,000. Keep gas scaled proportionate.
There was a problem hiding this comment.
I'd like to have 21000 as well but block 64 has more than 2000 transactions https://semux.info/explorer/block/65
There was a problem hiding this comment.
Yes. We still need to figure out a reasonable gas limit. Just one of my sample erc20 creates uses 2 mill gas... Had to bump up cost from old VM testnet for some reason. Not sure if bug or bugfix. So 15mil may be quite low
There was a problem hiding this comment.
@semuxgo I think even 5_000L is not enough. 1 month ago someone submitted 3237 TXs in one block. This one seems to be the biggest block of mainnet so far: https://semux.info/explorer/block/1405616
height | transactionsCount
---------+-------------------
1405616 | 3237
1399832 | 2941
66 | 2483
1405617 | 2338
65 | 2276
1405593 | 1734
1405494 | 1694
353180 | 1604
353176 | 1593
99479 | 1287
There was a problem hiding this comment.
I'm okay with bumping the block gas limit to resolve this issue. Currently, Ethereum has a gas limit of ~8mil. Don't want to go too high to avoid any unforeseen troubles.
There was a problem hiding this comment.
Also, I'm going to keep the 5000 gas for non-vm-transaction and the rational is that they can be executed more efficiently without launching a virtual machine. This would allow higher throughput without worrying about vm denial-of-service.
|
I think I'm going to merge this PR and push for the next release candidate. This would require some arrangements:
I'd rather not issue another fork just for the testnet. |
semuxgo
changed the title
To resolve issue #212
This PR intends to align the block gas limit with the transaction size limit, to ensure backwards compatibility.