-
Notifications
You must be signed in to change notification settings - Fork 31
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
API: divide APIs into groups #267
Conversation
- Deprecated POST/DELETE /account; - Replaced `/syncing` with `/syncing-status`; - Added `/create-account`; - Added `/delete-account`.
Maybe consider taking method 'safety' into consideration to better support what uses local wallet and what is gneric. Current public apis have to whitelist/blacklist based on which they choose that can be public |
Or make 'local wallet' only API separate port/config option to aid in spinning up a consistent public facing api |
Good point. I briefly looked at the HTTP method types being used. 99% of the GET methods are safe to be exposed to public. If we're okay with the following definition:
we can then add a flag to allow users to enable GET methods only if they want to make a public facing API. |
Hm. I don't think submit raw tx can be a GET due to url length? But I like where this isngoing |
Bumped the HTTP request size limits. Commit: 51fb2c1 Tested, working with both Java Client and Chrome. |
Ah. Ok. Thanks |
Description
This PR assigns endpoints to different categories, which include
Additional changes are also included:
Replaced/syncing
with/syncing-status
;/call
with/local-call
;Replaced/transaction/raw
with/broadcast-raw-transaction
;/transaction/raw
;POST /account
andDELETE /account
;/create-account
and/delete-account
;/local-create
;/broadcast-raw-transaction
.Test Plan
Existing tests
Related issues and/or PRs
N/A