Connect version 1.9.1: zlib used but not included in package.json

[qfan]

in ./lib/middleware/compress.js: var zlib = require('zlib');

but there is no corresponding dependency in package.json

This breaks automatic server setup. Please fix by either adding zlib dependency in package.json or remove the require('zlib'); from the code. Thanks.

[papandreou]

That would be https://github.com/joyent/node/blob/master/lib/zlib.js, which is built into node. It landed in node 0.5.8. If you're using a previous version of node, the compress middleware isn't supported in its current incarnation.

[qfan]

Thanks. We are using a much older version and currently we don't have the capacity to fully test our application with newer node.js.

The temporary solution we have is to run 'npm install zlib' explicitly before installing any other packages in package.json.
It works for now.

[druciak]

I agree with fanqi1234: for 0.4.x it should either detect whether 'zlib' is available and just not use compression if not or 'compress' middleware should be completely removed from 1.x branch. Please reopen.

[strk]

+1 on reopening I just got the zlib error while installing "express" with node-0.4.10

Would encoding the dependency on "zlib" install a duplicate when using a version of "node" with zlib built in ?

[tj]

@strk yeah it would be best as an optional-dependency since some people wont use it at all, and mostly because you have to compile which sucks

[tj]

actually it just shouldn't have been backported at all, it could have been a third-party backport with zlib as the dep

[strk]

On Tue, Jul 03, 2012 at 01:48:10PM -0700, TJ Holowaychuk wrote:

@strk yeah it would be best as an optional-dependency since some people wont use it at all, and mostly because you have to compile which sucks

I actually love compiling :)

--strk;

[tj]

well it's not a nice thing to force on people just for a backport :p

[TooTallNate]

cp.spawn('gzip') :p

[tj]

supes slow

[TooTallNate]

'twas partially a joke (I mean, people looking for good performance should upgrade to the latest node anyways)