Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(CLNP-1459): typing indicator bubble UI #146

Merged
merged 3 commits into from
Nov 21, 2023

Conversation

bang9
Copy link
Collaborator

@bang9 bang9 commented Nov 14, 2023

External Contributions

This project is not yet set up to accept pull requests from external contributors.

If you have a pull request that you believe should be accepted, please contact
the Developer Relations team developer-advocates@sendbird.com with details
and we'll evaluate if we can setup a CLA to allow for the contribution.

For Internal Contributors

CLNP-1459

Description Of Changes

  • Foundation: Add AvatarStack component
    image

    <Avatar.Stack>
      <Avatar />
      <Avatar />
      <Avatar />
    </Avatar.Stack>
  • Foundation: Add MessageTypingBubble component (animated)
    image

  • UIKit: Implement typing indicator types and typing bubble

    import { TypingIndicatorType } from '@sendbird/uikit-react-native';
    
    <SendbirdUIkitContainer
        uikitOptions={{
          groupChannel: {
            typingIndicatorTypes: new Set([TypingIndicatorType.Text, TypingIndicatorType.Bubble]),
          }
        }}
    />

Types Of Changes

What types of changes does your code introduce to this project?
Put an x in the boxes that apply_

  • Bugfix
  • New feature
  • Documentation (correction or otherwise)
  • Cosmetics (whitespace, appearance (ex) Prettier)
  • Build configuration
  • Improvement (refactor code)
  • Test

@bang9 bang9 self-assigned this Nov 14, 2023
@codecov-commenter
Copy link

codecov-commenter commented Nov 14, 2023

Codecov Report

Attention: 66 lines in your changes are missing coverage. Please review.

Comparison is base (c83e2b4) 13.02% compared to head (061a534) 12.91%.

Files Patch % Lines
...ct-native-foundation/src/ui/Avatar/AvatarStack.tsx 0.00% 31 Missing ⚠️
...-foundation/src/ui/TypingIndicatorBubble/index.tsx 0.00% 18 Missing ⚠️
...c/components/GroupChannelMessageRenderer/index.tsx 0.00% 7 Missing ⚠️
...main/groupChannel/component/GroupChannelHeader.tsx 0.00% 7 Missing ⚠️
...ative/src/fragments/createGroupChannelFragment.tsx 0.00% 3 Missing ⚠️
Additional details and impacted files
@@                          Coverage Diff                          @@
##           feat/typing-indicator-bubble/base     #146      +/-   ##
=====================================================================
- Coverage                              13.02%   12.91%   -0.12%     
=====================================================================
  Files                                    328      330       +2     
  Lines                                   7238     7300      +62     
  Branches                                2001     2015      +14     
=====================================================================
  Hits                                     943      943              
- Misses                                  6225     6287      +62     
  Partials                                  70       70              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@bang9 bang9 force-pushed the feat/typing-indicator-bubble/ui branch 2 times, most recently from 2e75a9c to 2e11e1c Compare November 14, 2023 10:11
Copy link

@liamcho liamcho left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM amazing work @bang9 !

@bang9 bang9 changed the base branch from feat/typing-indicator-bubble/base to main November 21, 2023 09:00
@bang9 bang9 force-pushed the feat/typing-indicator-bubble/ui branch from 061a534 to ad085de Compare November 21, 2023 09:02
@bang9 bang9 merged commit 8c67c31 into main Nov 21, 2023
6 checks passed
@bang9 bang9 deleted the feat/typing-indicator-bubble/ui branch November 21, 2023 11:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants