Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Update transitive dependencies #117

Merged

Conversation

kebeda
Copy link
Contributor

@kebeda kebeda commented Sep 16, 2019

Fixes #116

Checklist

  • I have made a material change to the repo (functionality, testing, spelling, grammar)
  • I have read the [Contribution Guide] and my PR follows them.
  • I updated my branch with the master branch.
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation about the functionality in the appropriate .md file
  • I have added in line documentation to the code I modified

Short description of what this PR does:

The PR updates transitive dependencies used by java-http-client;

  • org.apache.httpcomponents:httpcore:4.4.4 is upgraded to 4.4.12
  • org.apache.httpcomponents:httpclient:4.5.2 is upgraded to 4.5.10

These are fully backwardly compatible with what was there before.

ref. https://issues.apache.org/jira/browse/HTTPCLIENT-1743

`@Contract( threading = ThreadingBeahvior.UNSAFE )` is now default,
making this annotation no longer necessary.
@thinkingserious thinkingserious added the status: code review request requesting a community code review or review from Twilio label Sep 16, 2019
@SendGridDX
Copy link

SendGridDX commented Sep 16, 2019

CLA assistant check
All committers have signed the CLA.

@kebeda
Copy link
Contributor Author

kebeda commented Sep 16, 2019

Didn't check the last 3 checkboxes on the PR description because,

  • The existing tests cover this
  • No user-visible changes are in this PR
  • There was no code changed, hence no comment needed

@thinkingserious thinkingserious merged commit 0a70070 into sendgrid:master Nov 8, 2019
@thinkingserious
Copy link
Contributor

Hello @kebeda,

Thanks again for the PR!

We want to show our appreciation by sending you some swag. Could you please fill out this form so we can send it to you? Thanks!

Team SendGrid DX

@eshanholtz eshanholtz changed the title Update transitive dependencies chore: Update transitive dependencies Jan 31, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
status: code review request requesting a community code review or review from Twilio
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Bring Apache HttpComponents dependencies current
3 participants