Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: use .equals to compare strings #26

Merged
merged 5 commits into from
Nov 28, 2017
Merged

fix: use .equals to compare strings #26

merged 5 commits into from
Nov 28, 2017

Conversation

maxxedev
Copy link
Contributor

@maxxedev maxxedev commented Oct 4, 2017

No description provided.

@thinkingserious thinkingserious added the status: code review request requesting a community code review or review from Twilio label Oct 4, 2017
mbernier
mbernier reviewed Oct 11, 2017
View reviewed changes
Copy link
Contributor

@mbernier mbernier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like the change that you added, I just have the one question about the library that is imported.

src/main/java/com/sendgrid/Client.java Outdated
@@ -10,7 +10,7 @@
import java.util.Map;

import org.apache.http.Header;
import org.apache.http.StatusLine;
import org.apache.http.HttpMessage;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What's the benefit of this library over StatusLine?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

StatusLine import was removed because it wasn't needed.
HttpMessage import was added for new writeContentTypeIfNeeded() method.

@thinkingserious thinkingserious added difficulty: medium fix is medium in difficulty hacktoberfest labels Oct 11, 2017
@thinkingserious
Copy link
Contributor

Hi @maxxedev,

LGTM, could you please fix the merge conflict and I'll go ahead and merge.

With Best Regards,

Elmer

@thinkingserious thinkingserious merged commit d717011 into sendgrid:master Nov 28, 2017
@thinkingserious
Copy link
Contributor

Hello @maxxedev,

Thanks again for the PR!

We appreciate your contribution and look forward to continued collaboration. Thanks!

Team SendGrid DX

@eshanholtz eshanholtz changed the title use .equals to compare strings fix: use .equals to compare strings Jan 31, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mbernier mbernier mbernier left review comments

Assignees
No one assigned
Labels
difficulty: medium fix is medium in difficulty status: code review request requesting a community code review or review from Twilio
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@maxxedev @thinkingserious @mbernier @apigirl