Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Adding Docker support #67

Merged
merged 4 commits into from
Nov 13, 2017
Merged

feat: Adding Docker support #67

merged 4 commits into from
Nov 13, 2017

Conversation

mithunsasidharan
Copy link
Contributor

@mithunsasidharan mithunsasidharan commented Oct 29, 2017

Fixes #50

@thinkingserious thinkingserious added the status: code review request requesting a community code review or review from Twilio label Oct 29, 2017
@SendGridDX
Copy link

SendGridDX commented Oct 29, 2017

CLA assistant check
All committers have signed the CLA.

WORKDIR /root
RUN ln -s /root/sources/java-http-client/sendgrid

COPY entrypoint.sh entrypoint.sh
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I believe that there is an issue with the path here, I got the following error:

Removing intermediate container ffe1fcef3a69
Step 11/14 : COPY entrypoint.sh entrypoint.sh
COPY failed: stat /var/lib/docker/tmp/docker-builder064488478/entrypoint.sh: no such file or directory

@@ -0,0 +1,24 @@
FROM store/oracle/serverjre:8
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since this file is in the "docker" directory (this is awesome btw)
can you please make a change to src/test/TestRequiredFilesExist.java to fix the file path for the DockerFile?

line 10 should look like this:

    @Test public void checkDockerExists() {
        boolean dockerExists = new File("./docker/Dockerfile").exists() ||
        new File("./docker/Docker").exists();
        assertTrue(dockerExists);
    }

@mbernier
Copy link
Contributor

If you are interested, we would love the opportunity to talk to you about Hacktoberfest and our API libraries.

Our agenda would be: Explore what you liked and is there anything we can do to improve?

You can grab a time on my calendar that works for you and we can have a chat on Google Hangout or Skype. If you prefer, you can email me using my GitHub username at my company’s domain.

Thank you so much,

Matt Bernier - @mbernier - SendGrid Developer Experience Product Manager
Elmer Thomas - @thinkingserious - SendGrid Developer Experience Engineer
@sendgrid

@mithunsasidharan
Copy link
Contributor Author

mithunsasidharan commented Nov 13, 2017

@mbernier : Updated the PR.. can you please check now and let me know.

@mbernier
Copy link
Contributor

Thank you!!

@mbernier mbernier merged commit fa1f9a5 into sendgrid:master Nov 13, 2017
@thinkingserious
Copy link
Contributor

Hello @mithunsasidharan,

Thanks again for the PR!

We appreciate your contribution and look forward to continued collaboration. Thanks!

Team SendGrid DX

@eshanholtz eshanholtz changed the title Adding Docker support feat: Adding Docker support Jan 31, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
difficulty: hard fix is hard in difficulty status: code review request requesting a community code review or review from Twilio
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Java docker container
5 participants