Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Skip invalid content objects during serialization #531

Merged
merged 2 commits into from
Oct 31, 2017
Merged

Skip invalid content objects during serialization #531

merged 2 commits into from
Oct 31, 2017

Conversation

roel-de-vries
Copy link
Contributor

Issue #419: PR contains changes to skip and remove Content objects during serialization where either the Type or Value properties are set to empty or null strings.

@SendGridDX
Copy link

SendGridDX commented Oct 1, 2017 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

@thinkingserious thinkingserious added status: code review request requesting a community code review or review from Twilio difficulty: medium fix is medium in difficulty hacktoberfest labels Oct 1, 2017
@thinkingserious thinkingserious merged commit 5eb8d51 into sendgrid:master Oct 31, 2017
@thinkingserious
Copy link
Contributor

Hello @roel-de-vries,

Thanks again for the PR!

It's HACKTOBERFEST! We want to show our appreciation by sending you some special Hacktoberfest swag. If you have not already, could you please fill out this form so we can send it to you? Thanks!

Team SendGrid DX

@roel-de-vries roel-de-vries deleted the fix-template-addContent-method branch October 31, 2017 19:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
difficulty: medium fix is medium in difficulty status: code review request requesting a community code review or review from Twilio
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@roel-de-vries @SendGridDX @thinkingserious