.Net 4.5 References

[felipeleusin]

We don't need to reference the System.Net.Http package on .Net 4.5+ since it's provided by the framework.

I also update the targetFramework monikers to match the new ones at https://docs.microsoft.com/en-us/nuget/schema/target-frameworks

[SendGridDX]

All committers have signed the CLA.

[thinkingserious]

@felipeleusin

We have not been able to merge your Pull Request, but because you are awesome - we wanted to make sure you could still get a SendGrid Hacktoberfest shirt.

Please go fill out our swag form before Nov 5th and we will send the shirt! (We know that you might have tried this before and it didn’t work, sorry about that!)

You have till Nov 5th to fill out this form in order to get the Hacktoberfest shirt!

Thank you for contributing during Hacktoberfest! We hope to see you in the repos soon! Just so you know, we always give away a SendGrid shirt for your first ever non-Hacktoberfest PR that gets merged.

[bmeredith]

Would be great to see this merged in as we have been running into issues with System.Net.Http getting pulled in versus using the framework's assembly (we're running on .net 4.5+).

[thinkingserious]

Thanks for the additional feedback @bmeredith, your vote helps move this up our backlog queue.

[fpmess]

I'll second @bmeredith 's comment. Would be awesome if this was merged. We are running into a similar situation. Thanks!

[thinkingserious]

Thanks @fpmess!

[nboettcher]

I am running into the same issue as others posted, as well. Our app is .NET 4.5+.

[felipeleusin]

Hi. Is there any update on this? Just got bit by this again in. Is a simple update and a minor release

[thinkingserious]

Thanks for the additional vote @felipeleusin, this issue is still rising up our backlog and your vote helps that process move quicker. Thanks!

[felipeleusin]

Hi, any update on this? I can update this PR to target .Net Standart 2.0 if you need. Just saw this discussion:
https://twitter.com/terrajobst/status/997262020108926976 and remebered that this issue is still open

[thinkingserious]

Hi @felipeleusin,

This is still on our backlog waiting to bubble up. Unfortunately, I have quite a long list of issues before this one :(

I'm not sure if we want/need to update to .NET Standard 2.0 since 1.3 gives us broader support and we don't have any 2.0 specific functionality in this SDK.

With Best Regards,

Elmer

[xt0rted]

I'm not sure if we want/need to update to .NET Standard 2.0 since 1.3 gives us broader support and we don't have any 2.0 specific functionality in this SDK.

I think the idea is if you target both netstandard1.3 and netstandard2.0 then projects targeting .net core 2.0+ or full 4.6.1+ will have a simpler set of dependencies added. You can continue to use the .net standard 1.3 api, but I'm pretty sure targeting both versions will reduce the number of dependencies for newer versions of the framework.

[felipeleusin]

Not only that. There are problems when you reference the Nuget when you shouldn't. Specially with the changes from .Net Core 1 to 2, when they rolled back on bringing in all the framework packages locally. The folks at IdentityServer just published a post about this: https://leastprivilege.com/2018/05/21/the-state-of-httpclient-and-net-multi-targeting/ And every once in a while we have problems since the Nuget is a dependency.

[thinkingserious]

@xt0rted, @bmeredith,

Thanks for weighing in, much appreciated!

@felipeleusin,

Agreed, I think @xt0rted's approach is the way to go. Please move forward and I'll work to get this bumped in priority for merge.

[essmd]

Hi guys!

I am facing an assembly issue that seems to be caused by the System.Net.Http Reference.
Before i added the Sendgrid nuget package there was no warning / conflict because of any assembly or redirect missmatch. It seems like this PR would resolve that issue or i am missing something?

Assembly Redirects in all projects neither to 4.0.0.0 nor to 4.1.1.0 (from nuget command) nor 4.2.0.0 did work completely. They just generated much more warnings due to redirect conflicts.
By using the assembly redirect from 0.0.0.0-4.2.0.0 to new version 4.2.0.0 for System.Net.Http did resolve all warnings but not the last one (see screenshots below).

Project Setup:

ProjectA

• Framework: .NET Full Framework 4.7.1
• Nuget: Sendgrid 9.9.0 (latest)
• References: None (only the default). System.Net.Http is referenced due to Nuget Package dependency from sendgrid (path is correct!)

Project B

• Type: Console / Azure WebJobs (2.2)
• Framework: .NET Full Framework 4.7.1
• References: ProjectA (no reference to System.Net.Http)

Here are some screenshots from the Warning:

and also from the build output (details):

[thinkingserious]

Thanks @essmd,

I've added your vote to the PR internally to help move it up our priority queue.

[thinkingserious]

Hello @felipeleusin,

Thanks again for the PR!

We appreciate your contribution and look forward to continued collaboration. Thanks!

Team SendGrid DX