Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update documentation with new Git workflow #783

Merged
merged 2 commits into from
Oct 29, 2018
Merged

Update documentation with new Git workflow #783

merged 2 commits into from
Oct 29, 2018

Conversation

tony-ho
Copy link
Contributor

@tony-ho tony-ho commented Oct 13, 2018

Fixes

Fixes #781

Checklist

  • I have made a material change to the repo (functionality, testing, spelling, grammar)
  • I have read the [Contribution Guide] and my PR follows them.
  • I updated my branch with the master branch.
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation about the functionality in the appropriate .md file
  • I have added in line documentation to the code I modified

Short description of what this PR does:

  • Update CONTRIBUTING.md documentation, explaining the process of forking and branching off the development branch and submitting PRs against the development branch.
  • Update PULL_REQUEST_TEMPLATE with the same addition to the CONTRIBUTING.md documentation.

@thinkingserious thinkingserious added the status: code review request requesting a community code review or review from Twilio label Oct 13, 2018
@devchas devchas added difficulty: easy fix is easy in difficulty good first issue type: docs update documentation change not affecting the code labels Oct 17, 2018
@jonjenkins jonjenkins self-requested a review October 19, 2018 20:28
jonjenkins
jonjenkins approved these changes Oct 19, 2018
View reviewed changes
Copy link

@jonjenkins jonjenkins left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jonjenkins jonjenkins added status: ready for deploy code ready to be released in next deploy and removed status: code review request requesting a community code review or review from Twilio labels Oct 19, 2018
@thinkingserious
Copy link
Contributor

Hello @tony-ho,

Thanks again for the PR!

It's HACKTOBERFEST! We want to show our appreciation by sending you some special Hacktoberfest swag. If you have not already, could you please fill out this form so we can send it to you? Thanks!

Team SendGrid DX

@thinkingserious thinkingserious merged commit 32b5d8e into sendgrid:master Oct 29, 2018
@tony-ho tony-ho deleted the gitflow branch October 30, 2018 23:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jonjenkins jonjenkins jonjenkins approved these changes

Assignees
No one assigned
Labels
difficulty: easy fix is easy in difficulty status: ready for deploy code ready to be released in next deploy type: docs update documentation change not affecting the code
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Document new Git workflow in CHANGELOG.md
4 participants
@tony-ho @thinkingserious @jonjenkins @devchas