Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change the environment variable placeholders to be consistent amongst… #790

Merged
merged 1 commit into from
Oct 22, 2018
Merged

Change the environment variable placeholders to be consistent amongst… #790

merged 1 commit into from
Oct 22, 2018

Conversation

RossMacey
Copy link
Contributor

… all example projects.

Short description of what this PR does:

This changes "SENDGRID_API" placeholder to the more widely used "NAME_OF_THE_ENVIRONMENT_VARIABLE_FOR_YOUR_SENDGRID_KEY" within the two example projects specified above. This keeps the environment variables consistent amongst all example projects as well as being completely unambiguous as to what should be placed here.

If you have questions, please send an email to Sendgrid, or file a Github Issue in this repository.

@thinkingserious thinkingserious added the status: code review request requesting a community code review or review from Twilio label Oct 16, 2018
@SendGridDX
Copy link

SendGridDX commented Oct 16, 2018 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

jonjenkins
jonjenkins approved these changes Oct 19, 2018
View reviewed changes
Copy link

@jonjenkins jonjenkins left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM per https://sendgrid.com/blog/sendgrid-loves-developers/

@jonjenkins jonjenkins added hacktoberfest difficulty: easy fix is easy in difficulty status: ready for deploy code ready to be released in next deploy and removed status: code review request requesting a community code review or review from Twilio labels Oct 19, 2018
@thinkingserious thinkingserious merged commit bb2e623 into sendgrid:master Oct 22, 2018
@thinkingserious
Copy link
Contributor

Hello @RossMacey,

Thanks again for the PR!

It's HACKTOBERFEST! We want to show our appreciation by sending you some special Hacktoberfest swag. If you have not already, could you please fill out this form so we can send it to you? Thanks!

Team SendGrid DX

@thinkingserious
Copy link
Contributor

Hello @RossMacey,

Thanks again for the PR!

We noticed that you have earned 1 out of the 5 points needed to receive glorious SendGrid Hacktoberfest swag.

Please take a moment to checkout this link to find more issues to get you past the required threshold.

Also, please be sure that you have officially registered here.

Thank you and Happy Hacktobering!

Team SendGrid DX

@thinkingserious
Copy link
Contributor

Hello @RossMacey,

Thanks again for the PR!

You have earned 1 out of the 5 points needed to receive glorious SendGrid Hacktoberfest swag.

Please take a moment to checkout this link to find more issues to get you past the required threshold or to simply continue the celebration.

Also, please be sure you have officially registered with us here by November 1, 2018 to qualify.

If you have any questions you can email us at dx+hacktoberfest2018@sendgrid.com.

Thank you and Happy Hacktobering!

Team SendGrid

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jonjenkins jonjenkins jonjenkins approved these changes

Assignees
No one assigned
Labels
difficulty: easy fix is easy in difficulty status: ready for deploy code ready to be released in next deploy
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@RossMacey @SendGridDX @thinkingserious @jonjenkins