Refactoring SendGridClient to support inject external managed HttpClient #839
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thinkingserious
added
the
status: code review request
|
|
akunzai
changed the title
|
LGTM. This is one of the preconditions to having proper support for ASP.NET Core's DI paradigm, as you'd ideally have a single @thinkingserious Is there a reason this PR has been open for such a long period of time? |
|
conflicts solved for Twilio branding updates |
|
Thanks for helping out with a code review once again @aevitas! We appreciate it! |
thinkingserious
added
difficulty: medium
childish-sambino
pushed a commit
that referenced
this pull request
May 14, 2020
… its reliability settings Fixes #1000 Relates to #839 When the default client options were made static and the constructor was removed, there was no way to modify the reliability settings used by the retry handler. This fix adds back the constructor so clients can now be constructed with just the client options and the options will be used when creating a retry handled, if any.
childish-sambino
pushed a commit
that referenced
this pull request
May 14, 2020
… its reliability settings Fixes #1000 Relates to #839 When the default client options were made static and the constructor was removed, there was no way to modify the reliability settings used by the retry handler. This fix adds back the constructor so clients can now be constructed with just the client options and the options will be used when creating a retry handler, if any.
childish-sambino
pushed a commit
that referenced
this pull request
May 14, 2020
…e its reliability settings Fixes #1000 Relates to #839 When the default client options were made static and the constructors later removed, there was no way to modify the reliability settings used by the retry handler. This fix adds back the constructors so clients can now be constructed with just the client options and the options will be used when creating a retry handler, if any.
childish-sambino
pushed a commit
that referenced
this pull request
May 14, 2020
…e its reliability settings Fixes #1000 Relates to #839 When the default client options were made static and the constructors later removed, there was no way to modify the reliability settings used by the retry handler. This fix adds back the constructors so clients can now be constructed with just the client options and the options will be used when creating a retry handler, if any.
childish-sambino
pushed a commit
that referenced
this pull request
May 19, 2020
…e its reliability settings (#1001) Fixes #1000 Relates to #839 When the default client options were made static and the constructors later removed, there was no way to modify the reliability settings used by the retry handler. This fix adds back the constructors so clients can now be constructed with just the client options and the options will be used when creating a retry handler, if any.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #670
Fixes #897
Checklist
Short description of what this PR does: