-
Notifications
You must be signed in to change notification settings - Fork 587
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Implement IEquatable in EmailAddress #905
feat: Implement IEquatable in EmailAddress #905
Conversation
I just realised that this PR lacks the implementation of the equality operators as per the IEquatable documentation |
I've just finished implementing these. @thinkingserious PTAL. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me
Fixed the stack overflow issue and equality logic to only check the email address and make it case-insensitive per comment here: #425 (comment) |
Fixes #425
This pull request enables use of
Distinct()
et. al. on email addresses, allowing users to easily ensure no duplicate recipients exist, for instance when pulling recipients from a data source.Checklist
Short description of what this PR does:
IEquatable<EmailAddress>
inEmailAddress
Distinct()
on lists of e-mail addresses