Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Request adding http proxy support #138

Closed
phrinx opened this issue Sep 10, 2016 · 5 comments
Closed

Request adding http proxy support #138

phrinx opened this issue Sep 10, 2016 · 5 comments
Labels
status: help wanted requesting help from the community type: community enhancement feature request not on Twilio's roadmap

Comments

@phrinx
Copy link

phrinx commented Sep 10, 2016

earlier version of the lib provided a way to set http client, so any users was able to configure http proxy. for some reason this support was removed in v3? https://github.com/sendgrid/sendgrid-java/pull/27/files#diff-e71bc6d543f1733c4a2bdbb11c154eecR44

providing a way to pass in http client instance would also help: https://github.com/sendgrid/sendgrid-java/blob/v2.2.2/src/main/java/com/sendgrid/SendGrid.java#L88

@thinkingserious thinkingserious added type: community enhancement feature request not on Twilio's roadmap status: help wanted requesting help from the community labels Sep 12, 2016
@thinkingserious
Copy link
Contributor

Hi @phrinx,

This is now on our backlog to implement.

To help this issue rise up in our queue, it will need +1s or a pull request with a signed CLA.

Thanks!

@phrinx
Copy link
Author

phrinx commented Sep 12, 2016

Thanks. This is critical for us as we integrated a production system with large amounts of traffic with v2 (using http proxy for security purposes) and are blocked to upgrade to v3 since this support was dropped. Please consider prioritizing...

@thinkingserious
Copy link
Contributor

@phrinx,

We are not deprecating v2, so you are safe to continue using it until we make this upgrade.

@dmaicher
Copy link
Contributor

dmaicher commented Oct 9, 2016

I proposed a PR that should fix your issue: #158

That way you can do:

Client client = new Client(yourHttpClient);
SendGrid sendGrid = new SendGrid(apiKey, client);

thinkingserious added a commit that referenced this issue Oct 11, 2016
@thinkingserious
Copy link
Contributor

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
status: help wanted requesting help from the community type: community enhancement feature request not on Twilio's roadmap
Projects
None yet
Development

No branches or pull requests

3 participants