-
Notifications
You must be signed in to change notification settings - Fork 408
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Request adding http proxy support #138
Comments
Hi @phrinx, This is now on our backlog to implement. To help this issue rise up in our queue, it will need +1s or a pull request with a signed CLA. Thanks! |
Thanks. This is critical for us as we integrated a production system with large amounts of traffic with v2 (using http proxy for security purposes) and are blocked to upgrade to v3 since this support was dropped. Please consider prioritizing... |
We are not deprecating v2, so you are safe to continue using it until we make this upgrade. |
I proposed a PR that should fix your issue: #158 That way you can do: Client client = new Client(yourHttpClient);
SendGrid sendGrid = new SendGrid(apiKey, client); |
…ustom Client, http proxy support
Thanks to @dmaicher, we have a fix :) https://github.com/sendgrid/sendgrid-java/releases/tag/v3.1.0 |
earlier version of the lib provided a way to set http client, so any users was able to configure http proxy. for some reason this support was removed in v3? https://github.com/sendgrid/sendgrid-java/pull/27/files#diff-e71bc6d543f1733c4a2bdbb11c154eecR44
providing a way to pass in http client instance would also help: https://github.com/sendgrid/sendgrid-java/blob/v2.2.2/src/main/java/com/sendgrid/SendGrid.java#L88
The text was updated successfully, but these errors were encountered: