Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update documenation for retrieving a list of all templates (dynamic & legacy) #481

Closed
thinkingserious opened this issue Oct 6, 2018 · 6 comments · Fixed by #504
Closed
Labels
difficulty: easy fix is easy in difficulty type: docs update documentation change not affecting the code

Comments

@thinkingserious
Copy link
Contributor

thinkingserious commented Oct 6, 2018

Issue Summary

Please update the USAGE.md and corresponding \example with the call to list all templates.

This is the API call required: GET https://api.sendgrid.com/v3/templates?generations=legacy,dynamic

Acceptance Criteria

@thinkingserious thinkingserious added difficulty: medium fix is medium in difficulty hacktoberfest status: help wanted requesting help from the community type: docs update documentation change not affecting the code labels Oct 6, 2018
@thinkingserious
Copy link
Contributor Author

ankitmahapatra22 added a commit to ankitmahapatra22/sendgrid-java that referenced this issue Oct 6, 2018
ankitmahapatra22 added a commit to ankitmahapatra22/sendgrid-java that referenced this issue Oct 6, 2018
@devchas devchas added status: work in progress Twilio or the community is in the process of implementing and removed help wanted status: help wanted requesting help from the community labels Oct 17, 2018
@svachmic
Copy link

What is the status on using templates now? Both links on usage lead to legacy templates. Which templates are we supposed to be using now?

@childish-sambino childish-sambino added status: help wanted requesting help from the community and removed status: work in progress Twilio or the community is in the process of implementing labels Jul 10, 2020
@childish-sambino childish-sambino added difficulty: easy fix is easy in difficulty and removed status: help wanted requesting help from the community difficulty: medium fix is medium in difficulty labels Sep 21, 2020
@svachmic
Copy link

@childish-sambino why is this issue closed when it still hasn't been resolved? Everything is still legacy, nothing points to the new URLs, e.g. this one:

https://sendgrid.com/docs/ui/sending-email/how-to-send-an-email-with-dynamic-transactional-templates/

Or is this to be understood as ALL templates are now marked as legacy and we should look for a different solution as it won't be supported anymore? Thanks!

@childish-sambino
Copy link
Contributor

This issue is for updating the examples for retrieving all templates (default is legacy-only). This was fixed by #504

Transactional/dynamic template docs are already in the usage guide: https://github.com/sendgrid/sendgrid-java/blob/main/USE_CASES.md#transactional-templates

@svachmic
Copy link

@childish-sambino this sentence with a link:

For this example, we assume you have created a transactional template in the UI or via the API. Following is the template content we used for testing.

Is exactly the one I reported in the message above - the link under the transactional template leads to legacy documentation and not the most recent one.

@childish-sambino
Copy link
Contributor

Updated: b7de4b6

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
difficulty: easy fix is easy in difficulty type: docs update documentation change not affecting the code
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants