-
Notifications
You must be signed in to change notification settings - Fork 408
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use a newer version of Gradle that builds on modern JVM versions. #436
Use a newer version of Gradle that builds on modern JVM versions. #436
Conversation
There was a fairly indirect way of copying the fat jar to the root of the project, which I simplified, but it's not clear why that's desirable anyway.
Nice! Thanks for this contribution @marshallpierce! I've added this to our backlog for review. |
Any update on this? |
Hello @marshallpierce, This is still on our backlog for a code review. I've updated the tags for better visibility internally. Thanks for following up! With Best Regards, Elmer |
Hello @marshallpierce, |
Hello @marshallpierce, |
Hello @marshallpierce, |
Closing as gradle is no used. |
Checklist
Short description of what this PR does:
There was a fairly indirect way of copying the fat jar to the root of
the project, which I simplified, as it wasn't clear that it was being used.
The old tasks were creating a
-latest
jar (which is an antipattern, as that name will quickly become incorrect), and also appears to be using github as a jar distribution mechanism, which is also kind of against the grain of how the rest of the Java ecosystem works. If consumers do want a fat jar, it should probably be distributed like the other jars. BTW, I also suggest switching to Bintray for your distribution -- it's a lot easier to work with than Sonatype Nexus. I can help make that happen if you're game.The current behavior creates a
sendgrid-java-4.2.1-all.jar
file in the root of the project when you run the complete build. If someone can explain what is going with the whole/repo/com/sendgrid
structure, I can make that happen if it's still needed, but hopefully we can find a better way to accomplish whatever that was doing than copying jars around. :)