Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use a newer version of Gradle that builds on modern JVM versions. #436

Closed

Conversation

marshallpierce
Copy link

Checklist

  • I have made a material change to the repo (functionality, testing, spelling, grammar)
  • I have read the [Contribution Guide] and my PR follows them.
  • I updated my branch with the master branch.
  • I have added tests that prove my fix is effective or that my feature works
    • N/A. The build can run on Java 10, instead of crashing quickly.
  • I have added necessary documentation about the functionality in the appropriate .md file.
    • N/A, no functionality changes.
  • I have added in line documentation to the code I modified
    • N/A, no code modified.

Short description of what this PR does:

There was a fairly indirect way of copying the fat jar to the root of
the project, which I simplified, as it wasn't clear that it was being used.

The old tasks were creating a -latest jar (which is an antipattern, as that name will quickly become incorrect), and also appears to be using github as a jar distribution mechanism, which is also kind of against the grain of how the rest of the Java ecosystem works. If consumers do want a fat jar, it should probably be distributed like the other jars. BTW, I also suggest switching to Bintray for your distribution -- it's a lot easier to work with than Sonatype Nexus. I can help make that happen if you're game.

The current behavior creates a sendgrid-java-4.2.1-all.jar file in the root of the project when you run the complete build. If someone can explain what is going with the whole /repo/com/sendgrid structure, I can make that happen if it's still needed, but hopefully we can find a better way to accomplish whatever that was doing than copying jars around. :)

There was a fairly indirect way of copying the fat jar to the root of
the project, which I simplified, but it's not clear why that's desirable
anyway.
@thinkingserious thinkingserious added the status: code review request requesting a community code review or review from Twilio label May 15, 2018
@SendGridDX
Copy link
Collaborator

SendGridDX commented May 15, 2018

CLA assistant check
All committers have signed the CLA.

@thinkingserious
Copy link
Contributor

Nice!

Thanks for this contribution @marshallpierce!

I've added this to our backlog for review.

@marshallpierce
Copy link
Author

Any update on this?

@thinkingserious thinkingserious added type: community enhancement feature request not on Twilio's roadmap difficulty: medium fix is medium in difficulty labels Aug 14, 2018
@thinkingserious
Copy link
Contributor

Hello @marshallpierce,

This is still on our backlog for a code review. I've updated the tags for better visibility internally.

Thanks for following up!

With Best Regards,

Elmer

@thinkingserious thinkingserious added status: waiting for feedback waiting for feedback from the submitter and removed status: code review request requesting a community code review or review from Twilio labels Oct 3, 2018
@thinkingserious
Copy link
Contributor

Hello @marshallpierce,

Thanks again for the PR!

It's HACKTOBERFEST! We want to show our appreciation by sending you some special Hacktoberfest swag. If you have not already, could you please fill out this form so we can send it to you? Thanks!

Team SendGrid DX

@thinkingserious
Copy link
Contributor

Hello @marshallpierce,

Thanks again for the PR!

We noticed that you have earned 3 out of the 5 points needed to receive glorious SendGrid Hacktoberfest swag.

Please take a moment to checkout this link to find more issues to get you past the required threshold.

Also, please be sure that you have officially registered here.

Thank you and Happy Hacktobering!

Team SendGrid DX

@thinkingserious
Copy link
Contributor

Hello @marshallpierce,

Thanks again for the PR!

You have earned 3 out of the 5 points needed to receive glorious SendGrid Hacktoberfest swag.

Please take a moment to checkout this link to find more issues to get you past the required threshold or to simply continue the celebration.

Also, please be sure you have officially registered with us here by November 1, 2018 to qualify.

If you have any questions you can email us at dx+hacktoberfest2018@sendgrid.com.

Thank you and Happy Hacktobering!

Team SendGrid

@childish-sambino
Copy link
Contributor

Closing as gradle is no used.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
difficulty: medium fix is medium in difficulty status: waiting for feedback waiting for feedback from the submitter type: community enhancement feature request not on Twilio's roadmap
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants