Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test: Add spotbugs and checkstyle maven plugins for Travis CI #496

Merged
merged 5 commits into from
Aug 12, 2020
Merged

test: Add spotbugs and checkstyle maven plugins for Travis CI #496

merged 5 commits into from
Aug 12, 2020

Conversation

thatfiredev
Copy link
Contributor

Fixes

Fixes #472

Checklist

  • I have made a material change to the repo (functionality, testing, spelling, grammar)
  • I have read the [Contribution Guide] and my PR follows them.
  • I updated my branch with the master branch.
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation about the functionality in the appropriate .md file
  • I have added in line documentation to the code I modified

Short description of what this PR does:

  • Imports the spotbugs and checkstyle maven plugins
  • Tells Travis CI to run both spotbugs and checkstyle during build

I think I should also point out that our CONTRIBUTING.md requires the code to be run through findbugs, but the findbugs github repo mentions that the support for this tool ended on March 2015. The project is now called spotbugs and it's well maintained.

@thinkingserious thinkingserious added the status: code review request requesting a community code review or review from Twilio label Oct 12, 2018
@devchas devchas added difficulty: medium fix is medium in difficulty hacktoberfest status: work in progress Twilio or the community is in the process of implementing type: twilio enhancement feature request on Twilio's roadmap labels Oct 17, 2018
@thinkingserious thinkingserious added status: hacktoberfest approved and removed status: work in progress Twilio or the community is in the process of implementing labels Oct 23, 2018
@thinkingserious
Copy link
Contributor

Hello @rosariopfernandes,

Thanks again for the PR!

It's HACKTOBERFEST! We want to show our appreciation by sending you some special Hacktoberfest swag. If you have not already, could you please fill out this form so we can send it to you? Thanks!

Team SendGrid DX

@thinkingserious
Copy link
Contributor

Hello @rosariopfernandes,

Thanks again for the PR!

We noticed that you have earned 4 out of the 5 points needed to receive glorious SendGrid Hacktoberfest swag.

Please take a moment to checkout this link to find more issues to get you past the required threshold.

Also, please be sure that you have officially registered here.

Thank you and Happy Hacktobering!

Team SendGrid DX

RohanTalip added a commit to RohanTalip/sendgrid-java that referenced this pull request Oct 31, 2018
@RohanTalip
Tidied up a little.
58bf3e6 
- (Mostly) automatically reformatted code using IntelliJ IDEA to match the Google Style Guide (as documented in CONTRIBUTING.md).
  - 2 space indent, where it wasn't already.
  - Line wrap at 100 characters, where it wasn't already.
  - Wildcard imports were replaced with explicit imports.
  - Unused imports were removed.
  - Annotations were put onto their own line, and additional lines added for readability where necessary.
  - Braces were added to if-statements that didn't already have them.
- Also made some minor edits, e.g. as suggested by IntelliJ IDEA (e.g. public --> private).

This will help with getting the code into shape before style conformance is required as per issue sendgrid#472 and pull request sendgrid#496.

See also:
- https://github.com/google/google-java-format
- https://plugins.jetbrains.com/plugin/8527-google-java-format
- https://github.com/google/styleguide/blob/gh-pages/intellij-java-google-style.xml
@RohanTalip RohanTalip mentioned this pull request Oct 31, 2018
Merged
6 tasks
@thatfiredev thatfiredev changed the title chore: add spotbugs and checkstyle maven plugins for Travis CI Add spotbugs and checkstyle maven plugins for Travis CI Jan 1, 2019
RohanTalip added a commit to RohanTalip/sendgrid-java that referenced this pull request Feb 4, 2020
@RohanTalip
Tidied up a little.
f780c79 
- (Mostly) automatically reformatted code using IntelliJ IDEA to match the Google Style Guide (as documented in CONTRIBUTING.md).
  - 2 space indent, where it wasn't already.
  - Line wrap at 100 characters, where it wasn't already.
  - Wildcard imports were replaced with explicit imports.
  - Unused imports were removed.
  - Annotations were put onto their own line, and additional lines added for readability where necessary.
  - Braces were added to if-statements that didn't already have them.
- Also made some minor edits, e.g. as suggested by IntelliJ IDEA (e.g. public --> private).

This will help with getting the code into shape before style conformance is required as per issue sendgrid#472 and pull request sendgrid#496.

See also:
- https://github.com/google/google-java-format
- https://plugins.jetbrains.com/plugin/8527-google-java-format
- https://github.com/google/styleguide/blob/gh-pages/intellij-java-google-style.xml
RohanTalip added a commit to RohanTalip/sendgrid-java that referenced this pull request Feb 4, 2020
@RohanTalip
Tidied up a little.
e23f90f 
- (Mostly) automatically reformatted code using IntelliJ IDEA to match the Google Style Guide (as documented in CONTRIBUTING.md).
  - 2 space indent, where it wasn't already.
  - Line wrap at 100 characters, where it wasn't already.
  - Wildcard imports were replaced with explicit imports.
  - Unused imports were removed.
  - Annotations were put onto their own line, and additional lines added for readability where necessary.
  - Braces were added to if-statements that didn't already have them.
- Also made some minor edits, e.g. as suggested by IntelliJ IDEA (e.g. public --> private).

This will help with getting the code into shape before style conformance is required as per issue sendgrid#472 and pull request sendgrid#496.

See also:
- https://github.com/google/google-java-format
- https://plugins.jetbrains.com/plugin/8527-google-java-format
- https://github.com/google/styleguide/blob/gh-pages/intellij-java-google-style.xml
RohanTalip added a commit to RohanTalip/sendgrid-java that referenced this pull request Feb 21, 2020
@RohanTalip
Tidied up a little.
e2e146b 
- (Mostly) automatically reformatted code using IntelliJ IDEA to match the Google Style Guide (as documented in CONTRIBUTING.md).
  - 2 space indent, where it wasn't already.
  - Line wrap at 100 characters, where it wasn't already.
  - Wildcard imports were replaced with explicit imports.
  - Unused imports were removed.
  - Annotations were put onto their own line, and additional lines added for readability where necessary.
  - Braces were added to if-statements that didn't already have them.
- Also made some minor edits, e.g. as suggested by IntelliJ IDEA (e.g. public --> private).

This will help with getting the code into shape before style conformance is required as per issue sendgrid#472 and pull request sendgrid#496.

See also:
- https://github.com/google/google-java-format
- https://plugins.jetbrains.com/plugin/8527-google-java-format
- https://github.com/google/styleguide/blob/gh-pages/intellij-java-google-style.xml
@childish-sambino childish-sambino removed the type: twilio enhancement feature request on Twilio's roadmap label Jul 20, 2020
@thinkingserious thinkingserious changed the base branch from master to main July 28, 2020 14:33
@childish-sambino childish-sambino changed the title Add spotbugs and checkstyle maven plugins for Travis CI test: Add spotbugs and checkstyle maven plugins for Travis CI Aug 12, 2020
@childish-sambino childish-sambino merged commit fe30aed into sendgrid:main Aug 12, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@childish-sambino childish-sambino childish-sambino approved these changes

Assignees
No one assigned
Labels
difficulty: medium fix is medium in difficulty status: code review request requesting a community code review or review from Twilio
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Require conformance to style standards
4 participants
@thatfiredev @thinkingserious @childish-sambino @devchas