-
Notifications
You must be signed in to change notification settings - Fork 409
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: verify signature from event webhook #622
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
77ac842
to
8fa79e6
Compare
thavanle
reviewed
May 6, 2020
src/main/java/com/sendgrid/helpers/eventsettings/EventWebhook.java
Outdated
Show resolved
Hide resolved
9abeb5c
to
3b87bde
Compare
3b87bde
to
94d2bc1
Compare
Can we rename the directory "eventsettings" to "eventwebhook" instead please? I know it stutters a little bit for helpers/eventwebhook/EventWebhook.java, but I think it is ok in this context. |
src/main/java/com/sendgrid/helpers/eventwebhook/EventWebhook.java
Outdated
Show resolved
Hide resolved
src/main/java/com/sendgrid/helpers/eventwebhook/EventWebhook.java
Outdated
Show resolved
Hide resolved
src/main/java/com/sendgrid/helpers/eventwebhook/EventWebhookHeader.java
Outdated
Show resolved
Hide resolved
src/test/java/com/sendgrid/helpers/eventwebhook/EventWebhookTest.java
Outdated
Show resolved
Hide resolved
src/test/java/com/sendgrid/helpers/eventwebhook/EventWebhookTest.java
Outdated
Show resolved
Hide resolved
150d007
to
dd8cfd8
Compare
childish-sambino
approved these changes
May 7, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes
When enabling the "Signed Event Webhook Requests" feature in Mail Settings, Twilio SendGrid will generate a private and public key pair using the Elliptic Curve Digital Signature Algorithm (ECDSA). Once that is successfully enabled, all new event posts will have two new headers:
X-Twilio-Email-Event-Webhook-Signature
andX-Twilio-Email-Event-Webhook-Timestamp
, which can be used to validate your events.This SDK update will make it easier to verify signatures from signed event webhook requests by using the
VerifySignature
method. Pass in the public key, event payload, signature, and timestamp to validate. Note: You will need to convert your public key string to an elliptic public key object in order to use theVerifySignature
method.I want to give a shoutout to @thavanle for helping me create this new feature. Thanks @thavanle for helping more developers use Twilio SendGrid securely!
Checklist
If you have questions, please file a support ticket, or create a GitHub Issue in this repository.