Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Add data residency for eu and global regions #743

Merged
merged 3 commits into from
Nov 2, 2023
Merged

feat: Add data residency for eu and global regions #743

merged 3 commits into from
Nov 2, 2023

Conversation

shrutiburman
Copy link
Contributor

@shrutiburman shrutiburman commented Nov 1, 2023 •
edited
Loading

Related ticket: DII-1228
Reference doc

Fixes

A short description of what this PR does.

Checklist

  • I acknowledge that all my contributions will be made under the project's license
  • I have made a material change to the repo (functionality, testing, spelling, grammar)
  • I have read the Contribution Guidelines and my PR follows them
  • I have titled the PR appropriately
  • I have updated my branch with the main branch
  • I have added tests that prove my fix is effective or that my feature works
  • I have added the necessary documentation about the functionality in the appropriate .md file
  • I have added inline documentation to the code I modified

If you have questions, please file a support ticket.

gladysmae08
gladysmae08 reviewed Nov 1, 2023
View reviewed changes
Copy link

@gladysmae08 gladysmae08 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CR

src/test/java/com/sendgrid/SendGridTest.java Outdated Show resolved Hide resolved
@gladysmae08
Copy link

I'd recommend adding some info in the README or Example Use cases, unless you think this is adequately documented in the Sendgrid API Documentation

@shrutiburman
Copy link
Contributor Author

I'd recommend adding some info in the README or Example Use cases, unless you think this is adequately documented in the Sendgrid API Documentation

I have added an example folder for now. The documentation change is planned but not in place yet.

tbischel
tbischel approved these changes Nov 2, 2023
View reviewed changes
Copy link

@tbischel tbischel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@shrutiburman shrutiburman merged commit 040d916 into main Nov 2, 2023
9 checks passed
@shrutiburman shrutiburman deleted the DII1228-add-data-residency branch November 2, 2023 18:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gladysmae08 gladysmae08 gladysmae08 approved these changes

@tbischel tbischel tbischel approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@shrutiburman @gladysmae08 @tbischel