Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix batch_id type #399

Merged
merged 1 commit into from
Jun 30, 2017
Merged

Fix batch_id type #399

merged 1 commit into from
Jun 30, 2017

Conversation

testica
Copy link
Contributor

@testica testica commented Jun 30, 2017

batch_id is a string according to Sendgrid documentation, but in index.d.ts file batch_id is considered a number.

@thinkingserious thinkingserious added the status: code review request requesting a community code review or review from Twilio label Jun 30, 2017
@SendGridDX
Copy link
Collaborator

SendGridDX commented Jun 30, 2017 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

@thinkingserious thinkingserious merged commit d2235a0 into sendgrid:master Jun 30, 2017
@thinkingserious
Copy link
Contributor

Hello @testica,

Thanks again for the PR!

We want to show our appreciation by sending you some swag. Could you please fill out this form so we can send it to you? Thanks!

Team SendGrid DX

thinkingserious added a commit that referenced this pull request Jun 30, 2017
@thinkingserious
Version Bump v5.1.2: PR #399: Fix type
ac1818c
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
status: code review request requesting a community code review or review from Twilio
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@testica @SendGridDX @thinkingserious