-
Notifications
You must be signed in to change notification settings - Fork 626
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for commas and semicolons in email name and add test #511
Conversation
We have not been able to merge your Pull Request, but because you are awesome - we wanted to make sure you could still get a SendGrid Hacktoberfest shirt. Please go fill out our swag form before Nov 5th and we will send the shirt! (We know that you might have tried this before and it didn’t work, sorry about that!) You have till Nov 5th to fill out this form in order to get the Hacktoberfest shirt!Thank you for contributing during Hacktoberfest! We hope to see you in the repos soon! Just so you know, we always give away a SendGrid shirt for your first ever non-Hacktoberfest PR that gets merged. |
Hey, |
Hello @qligier, I'm not sure if your PR will require any changes just yet. We are processing all of the PRs from oldest to newest and we had over 1,000 PRs this hacktoberfest, so we are a bit (OK, a lot) behind :) Thank you for your contribution and patience! With Best Regards, Elmer |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This test really lives up, and performs the job well.
Hello @qligier, Could you please resolve the conflicts so that I can merge this? Thanks! |
It's done. There is an issue with composer when using PHP 7 but tests have passed with PHP 5.6 in Travis CI. |
Hello @qligier, |
The backend has been updated to properly handling names with special characters so the original "fix" is no longer needed. Reverts #511
The backend has been updated to properly handling names with special characters so the original "fix" is no longer needed. Reverts #511
This PR fixes issue #368 and replaces #370. It wraps the email name in double quotes when commas or semicolons are present (without, the mail would be rejected by the API).
I've added unit test to check the behavior of the
Sendgrid\Email->setName()
method. I've also sent real emails with various names to verify that they are delivered.I've also added a comment explaining the issue because the patch should be reverted if the API is modified to support commas and semicolons.