Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added CodeCov support #542

Merged
merged 1 commit into from
Dec 11, 2017
Merged

Conversation

owenvoke
Copy link
Contributor

Fixes #541

Checklist

  • I have made a material change to the repo (functionality, testing, spelling, grammar)
  • I have read the [Contribution Guide] and my PR follows them.
  • I updated my branch with the master branch.
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation about the functionality in the appropriate .md file
  • I have added in line documentation to the code I modified

Short description of what this PR does:

I haven't checked everything on the list as it wasn't really relevant. I've tested the commit in my Travis CI instance though.

@thinkingserious thinkingserious added the status: code review request requesting a community code review or review from Twilio label Oct 30, 2017
@SendGridDX
Copy link

SendGridDX commented Oct 30, 2017

CLA assistant check
All committers have signed the CLA.

@codecov
Copy link

codecov bot commented Oct 31, 2017

Codecov Report

❗ No coverage uploaded for pull request base (master@757e2b5). Click here to learn what that means.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##             master     #542   +/-   ##
=========================================
  Coverage          ?   96.71%           
=========================================
  Files             ?        2           
  Lines             ?      487           
  Branches          ?        0           
=========================================
  Hits              ?      471           
  Misses            ?       16           
  Partials          ?        0

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 757e2b5...7204c80. Read the comment docs.

@owenvoke
Copy link
Contributor Author

I don't think this can actually be resolved by me, because there was no coverage before as that's the feature I added. 🤔

@mbernier mbernier added the difficulty: medium fix is medium in difficulty label Dec 11, 2017
@mbernier mbernier merged commit 0a4f9be into sendgrid:master Dec 11, 2017
@thinkingserious
Copy link
Contributor

Hello @pxgamer,

Thanks again for the PR!

We appreciate your contribution and look forward to continued collaboration. Thanks!

Team SendGrid DX

@mbernier
Copy link

@pxgamer

If you are interested, we would love the opportunity to talk to you about Hacktoberfest and our API libraries.

Our agenda would be: Explore what you liked and is there anything we can do to improve?

You can grab a time on my calendar that works for you and we can have a chat on Google Hangout or Skype. If you prefer, you can email me using my GitHub username at my company’s domain.

Thank you so much,

Matt Bernier - @mbernier - SendGrid Developer Experience Product Manager
Elmer Thomas - @thinkingserious - SendGrid Developer Experience Engineer
@sendgrid

@owenvoke owenvoke deleted the feature/codecov-support branch October 29, 2018 16:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
difficulty: medium fix is medium in difficulty status: code review request requesting a community code review or review from Twilio
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add CodeCov support to .travis.yml
5 participants