Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update CONTRIBUTING.md #545

Merged
merged 1 commit into from
Mar 24, 2018
Merged

Conversation

thepriefy
Copy link
Contributor

@thepriefy thepriefy commented Oct 31, 2017

Checklist

  • I have made a material change to the repo (functionality, testing, spelling, grammar)
  • I have read the [Contribution Guide] and my PR follows them.
  • I updated my branch with the master branch.
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation about the functionality in the appropriate .md file
  • I have added in line documentation to the code I modified

Short description of what this PR does:

  • makes Environment Variables as a sub topic

If you have questions, please send an email to Sendgrid, or file a Github Issue in this repository.

makes Environment Variables as a sub topic
@thinkingserious thinkingserious added the status: code review request requesting a community code review or review from Twilio label Oct 31, 2017
@SendGridDX
Copy link

SendGridDX commented Oct 31, 2017

CLA assistant check
All committers have signed the CLA.

@thinkingserious thinkingserious added the status: code review request requesting a community code review or review from Twilio label Nov 1, 2017
@thinkingserious thinkingserious added type: bug bug in the library difficulty: easy fix is easy in difficulty type: docs update documentation change not affecting the code labels Feb 28, 2018
@thinkingserious thinkingserious merged commit 2288be0 into sendgrid:master Mar 24, 2018
@thinkingserious
Copy link
Contributor

Hello @thepriefy,

Thanks again for the PR!

We appreciate your contribution and look forward to continued collaboration. Thanks!

Team SendGrid DX

@thepriefy thepriefy deleted the patch-1 branch March 24, 2018 04:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
difficulty: easy fix is easy in difficulty status: code review request requesting a community code review or review from Twilio type: bug bug in the library type: docs update documentation change not affecting the code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants