-
Notifications
You must be signed in to change notification settings - Fork 626
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Attachments now automatically get base64 encoded if they are not already #618
Attachments now automatically get base64 encoded if they are not already #618
Conversation
Nicely done @martijnmelchers! We just need to add some tests to get this one merged. Do you have time to do that? |
Sure will do that today! |
@thinkingserious In what file should the tests be created? |
How about BTW, have you been able to get the tests running locally using Docker? |
I'm not able to get the Docker thing running, so I might not be able to run tests. How should I proceed? |
I will help you with that. Please email me at dx@sendgrid.com and let me know where you are stuck. Thanks! |
There seems to be a difference in PHP 7.1 and up with |
Ok cool! I have figured it out! Will finish some PHPDocs and then you will be able to merge it! |
Awesome! Is this ready to go? |
Yes its ready!
|
Hello @martijnmelchers, |
Fixes
Fixes #611
Checklist
Short description of what this PR does: