fix: refactor and fix personalization inserts/updates #952
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thinkingserious
added
the
status: code review request
childish-sambino
force-pushed
the
personalizations
branch
2 times, most recently
from
424bb17 to
0a9ed65
Compare
childish-sambino
force-pushed
the
personalizations
branch
from
0a9ed65 to
66fd465
Compare
eshanholtz
reviewed
Apr 21, 2020
| return; | ||
| } | ||
|
|
||
| $personalization = $this->getPersonalization($personalizationIndex, $personalization); |
eshanholtz
reviewed
Apr 21, 2020
|
|
||
| $json = json_encode($objEmail, JSON_PRETTY_PRINT); | ||
|
|
||
| $expectedJson = <<<JSON |
There was a problem hiding this comment.
That's cool. I didn't know you could do that.
There was a problem hiding this comment.
/me copied it from above
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #614
Fixes #616
Fixes #819
Fixes #873
Fixes #849
Fixes #607