fix: Accept string typed Subject in Personalization #974
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Updated code base from upstream repository
Update repository using sendgrid/master
Sync local repository using original
Update repository using sendgrid/master
- Added support for string typed Subject (was allowed according to unit tests) - getSubject(): added null return type if no subject is attached Subject: - Tabs to spaces (EditorConfig) - TypeException hint (same namespace) Unit tests: MultipleEmailToMultipleRecipientsTest - Methods testWithCollectionOfSubjects*() were failing, if providing string[] instead of Subject[], a TypeException was thrown and expected as outcome (which was incorrect) - JSON output (which was never compared due to the TypeException) of method testWithCollectionOfSubjectsDynamic() was compared against wrong result MailHelperTest (unrelated) - Use compareJSONObjects instead of JSON string comparing (locally failing on newlines) Signed-off-by: Alexander Kamp <git@akamp.nl>
thinkingserious
added
the
status: code review request
|
Nice work, thank you! |
thinkingserious
approved these changes
Jun 5, 2020
thinkingserious
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
During work on
PersonalizationI ran into a few issues. I've decided to split the PR to keep the overview. This PR is related toSubject.A few unit test assertions were relying on
expectedExceptiontype hints, which were triggered bysetSubject()(using string value) ontoPersonalization. However, this is not the expected outcome but it was allowed. After fixing, I've discovered one assertion is compared against the wrong JSON expectation.The usage suggests to allow string values for
Subject. That makes sense and it can be created easily. If unwanted, please report it.For (unrelated) unit test
MailHelperTestI replacedassertEqualsbycompareJSONObjects. It ignores the newlines and gives no different result.Checklist