feat: Mail constructor: Added support for array of Substitution instances using $globalSubstitutions #978
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
Mail
constructor offers argument$globalSubstitutions
.While studying
testWithIndividualSubjectsDynamicTemplates
, mentioned argument is highlighted because an array isn't expected here. Current PHPDoc defines 'array ofSubstitution
instances' ornull
, but not a normal array. To fix this, I've addedarray
as expected datatype in PHPDoc.In addition, passing an 'array of
Substitution
instances' will be processed properly.ps. Maybe a better description of 'how to use the constructor' can be defined. I am open to feedback.
Checklist