feat: add support for Twilio Email #882
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thinkingserious
added
the
status: code review request
Codecov Report
@@ Coverage Diff @@
## master #882 +/- ##
==========================================
+ Coverage 82.48% 82.63% +0.14%
==========================================
Files 70 72 +2
Lines 2312 2326 +14
Branches 340 340
==========================================
+ Hits 1907 1922 +15
+ Misses 206 205 -1
Partials 199 199
Continue to review full report at Codecov.
|
eshanholtz
reviewed
Apr 21, 2020
| @@ -0,0 +1,54 @@ | |||
| ## 1. Obtain a Free Twilio Account | |||
There was a problem hiding this comment.
Do you have these files in the bootstrap command for sendgrid libs in librarian?
There was a problem hiding this comment.
No, there's nothing in librarian which does different bootstrapping based on org yet. Plus the files aren't always in the same place. I think there's another backlog item about cleaning this up across the repos.
eshanholtz
approved these changes
Apr 21, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.