Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: Add License end year test #41

Merged
merged 1 commit into from
Oct 31, 2017
Merged

chore: Add License end year test #41

merged 1 commit into from
Oct 31, 2017

Conversation

diegous
Copy link

@diegous diegous commented Oct 28, 2017

Fixes #38

Checklist

  • I have made a material change to the repo (functionality, testing, spelling, grammar)
  • I have read the [Contribution Guide] and my PR follows them.
  • I updated my branch with the master branch.
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation about the functionality in the appropriate .md file
  • I have added in line documentation to the code I modified

@thinkingserious thinkingserious added the status: code review request requesting a community code review or review from Twilio label Oct 28, 2017
@SendGridDX
Copy link

SendGridDX commented Oct 28, 2017 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

@thinkingserious thinkingserious added difficulty: medium fix is medium in difficulty hacktoberfest labels Oct 29, 2017
@diegous diegous force-pushed the add-license-end-year-test branch from 8452b96 to c062e94 Compare October 31, 2017 18:33
@diegous diegous force-pushed the add-license-end-year-test branch from c062e94 to f60b6ea Compare October 31, 2017 18:46
@sendgrid sendgrid deleted a comment from SendGridDX Oct 31, 2017
@mbernier
Copy link

I love your honesty about reading the contribution guide. We had a giggle. Thank you.

@mbernier mbernier merged commit 9ae5fc6 into sendgrid:master Oct 31, 2017
@thinkingserious
Copy link

Hello @diegous,

Thanks again for the PR!

It's HACKTOBERFEST! We want to show our appreciation by sending you some special Hacktoberfest swag. If you have not already, could you please fill out this form so we can send it to you? Thanks!

Team SendGrid DX

@thinkingserious thinkingserious changed the title Add License end year test chore: Add License end year test Jan 9, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
difficulty: medium fix is medium in difficulty status: code review request requesting a community code review or review from Twilio
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add a unittest to check the license.md file date range
4 participants
@diegous @SendGridDX @mbernier @thinkingserious