chore: Replaced .length > 0 with .!empty? #46
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thinkingserious
added
the
status: code review request
|
|
|
@thinkingserious please review. |
mbernier
suggested changes
Nov 21, 2017
lib/smtpapi.rb
Outdated
| @@ -116,20 +116,20 @@ def set_ip_pool(pool_name) | |||
|
|
|||
| def to_array | |||
| data = {} | |||
| data['to'] = @to if @to.length > 0 | |||
There was a problem hiding this comment.
It looks like the Travis build is having some issues with the .emtpy? calls here: https://travis-ci.org/sendgrid/smtpapi-ruby/builds/294550416#L652
Can you please look into this and see what's causing these errors?
mbernier
approved these changes
Dec 11, 2017
|
Hello @nvzard, |
thinkingserious
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #32
Checklist
Short description of what this PR does:
If you have questions, please send an email to Sendgrid, or file a Github Issue in this repository.