Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Resolve linting issues. #64

Merged
merged 5 commits into from
Oct 2, 2018

Conversation

mrala
Copy link

@mrala mrala commented Oct 1, 2018

Resolves #63.

  • I have made a material change to the repo (functionality, testing, spelling, grammar)

  • I have read the [Contribution Guide] and my PR follows them.

  • I updated my branch with the master branch.

  • I have added tests that prove my fix is effective or that my feature works

  • I have added necessary documentation about the functionality in the appropriate .md file

  • I have added in line documentation to the code I modified

  • Clean up rubopcop issues

If you have questions, please send an email to Sendgrid, or file a Github Issue in this repository.

Signed-off-by: Ali Yahya <amyahya@gmail.com>
@thinkingserious thinkingserious added the status: code review request requesting a community code review or review from Twilio label Oct 1, 2018
@SendGridDX
Copy link

SendGridDX commented Oct 1, 2018

CLA assistant check
All committers have signed the CLA.

mrala added 4 commits October 1, 2018 13:21
Signed-off-by: Ali Yahya <amyahya@gmail.com>
Signed-off-by: Ali Yahya <amyahya@gmail.com>
Signed-off-by: Ali Yahya <amyahya@gmail.com>
Signed-off-by: Ali Yahya <amyahya@gmail.com>
@thinkingserious thinkingserious added difficulty: medium fix is medium in difficulty hacktoberfest status: ready for deploy code ready to be released in next deploy labels Oct 2, 2018
@thinkingserious
Copy link

Hello @mrala,

Thanks again for the PR!

It's HACKTOBERFEST! We want to show our appreciation by sending you some special Hacktoberfest swag. If you have not already, could you please fill out this form so we can send it to you? Thanks!

Team SendGrid DX

@sendgrid sendgrid deleted a comment from SendGridDX Oct 2, 2018
@thinkingserious thinkingserious merged commit 42972dc into sendgrid:master Oct 2, 2018
@mrala mrala deleted the rubocop_fixes branch October 2, 2018 23:33
@mrala
Copy link
Author

mrala commented Oct 2, 2018

Not a problem, @thinkingserious! Just a heads up, I believe this also resolves #60.

@thinkingserious
Copy link

Awesome, thanks for the heads up @mrala!

@thinkingserious
Copy link

Hello @mrala,

Thanks again for the PR!

We noticed that you have earned 3 out of the 5 points needed to receive glorious SendGrid Hacktoberfest swag.

Please take a moment to checkout this link to find more issues to get you past the required threshold.

Also, please be sure that you have officially registered here.

Thank you and Happy Hacktobering!

Team SendGrid DX

@thinkingserious
Copy link

Hello @mrala,

Thanks again for the PR!

You have earned 3 out of the 5 points needed to receive glorious SendGrid Hacktoberfest swag.

Please take a moment to checkout this link to find more issues to get you past the required threshold or to simply continue the celebration.

Also, please be sure you have officially registered with us here by November 1, 2018 to qualify.

If you have any questions you can email us at dx+hacktoberfest2018@sendgrid.com.

Thank you and Happy Hacktobering!

Team SendGrid

@thinkingserious thinkingserious changed the title Resolve linting issues. chore: Resolve linting issues. Jan 9, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
difficulty: medium fix is medium in difficulty status: code review request requesting a community code review or review from Twilio status: ready for deploy code ready to be released in next deploy
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Small fixes for clarity and readability
3 participants