Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Add test coverage analysis #87

Merged

Conversation

RolandBurrows
Copy link

Short description of what this PR does:

As a contributor, I'd like to know what baseline code coverage is and how my enhancements affect it.

No documentation was updated because code coverage is now part of the default rake test run, with no further action required.

smtpapi-ruby$ rake test

<test debug info>
Coverage report generated for Unit Tests, Unknown Test Framework,
test:units to ../smtpapi-ruby/coverage. 101 / 101 LOC (100.0%) covered.

Checklist

  • I have made a material change to the repo (functionality, testing, spelling, grammar)
  • I have read the [Contribution Guide] and my PR follows them.
  • I updated my branch with the master branch.
  • (N/A) I have added tests that prove my fix is effective or that my feature works
  • (N/A) I have added necessary documentation about the functionality in the appropriate .md file
  • (N/A) I have added in line documentation to the code I modified

@thinkingserious thinkingserious added the status: code review request requesting a community code review or review from Twilio label Nov 1, 2018
@SendGridDX
Copy link

SendGridDX commented Nov 1, 2018

CLA assistant check
All committers have signed the CLA.

@sendgrid sendgrid deleted a comment from SendGridDX Nov 2, 2018
@thinkingserious thinkingserious changed the title Add test coverage analysis chore: Add test coverage analysis Feb 19, 2020
@thinkingserious thinkingserious merged commit d08909c into sendgrid:master Feb 19, 2020
@thinkingserious
Copy link

Hello @RolandBurrows,

Thanks again for the PR!

We want to show our appreciation by sending you some swag. Could you please fill out this form so we can send it to you? Thanks!

Team SendGrid DX

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
difficulty: medium fix is medium in difficulty status: code review request requesting a community code review or review from Twilio
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants