Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

blocks: Fix an issue where block is not rendering due to badly formatted autoresponders #142

Merged
merged 3 commits into from
Oct 24, 2024
Merged

blocks: Fix an issue where block is not rendering due to badly formatted autoresponders #142

merged 3 commits into from
Oct 24, 2024

Conversation

sinukaarel
Copy link
Contributor

@sinukaarel sinukaarel commented Oct 24, 2024 •
edited
Loading

Plugin Version : 3.1.3

Fixes an issue where the blocks section is not parsing an autoresponder list out of JSON object. This causes the section to fail and display an error. The autoresponders list should be a JSON string, not an object.

Release checklist

  • Added release tag to this pull request
  • Updated README.md
  • Updated readme.txt
  • Updated CHANGELOG.md
  • Updated CONTRIBUTION.md
  • Updated plugin version number
  • Ensure schema and data migrations are created
  • Updated screenshots in assets folder
  • Updated translations

After PR merge

  • Released new version in GitHub
  • Ran the release.sh script to publish plugin to WordPress plugin library
  • Pinged code owners to inform marketing about new version

@sinukaarel
blocks: Fix an issue where block is not rendering due to badly format…
f8e30d1 
…ted autoresponders

Fixes an issue where blocks section is not parsing an autoresponder list out of JSON object. This causes section to fail and display an error. The autoresponders list should be an JSON string not an object.
@sinukaarel sinukaarel added the bug Something isn't working label Oct 24, 2024
@sinukaarel sinukaarel self-assigned this Oct 24, 2024
@sinukaarel sinukaarel added the release Release a new version label Oct 24, 2024
@sinukaarel sinukaarel requested a review from kaittodesk October 24, 2024 07:40
kaittodesk
kaittodesk requested changes Oct 24, 2024
View reviewed changes
admin/class-smaily-for-wp-admin.php Outdated Show resolved Hide resolved
@sinukaarel sinukaarel requested a review from kaittodesk October 24, 2024 10:04
kaittodesk
kaittodesk requested changes Oct 24, 2024
View reviewed changes
admin/class-smaily-for-wp-admin.php Outdated Show resolved Hide resolved
@sinukaarel sinukaarel merged commit ff24d98 into master Oct 24, 2024
@sinukaarel sinukaarel deleted the fix/json-encode-autoresponders branch October 24, 2024 13:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kaittodesk kaittodesk kaittodesk approved these changes

Assignees

@sinukaarel sinukaarel

Labels
bug Something isn't working release Release a new version
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sinukaarel @kaittodesk