Skip to content

Commit

Permalink
provider: Fix Defined.net HTTP API client's host update endpoint (#12)
Browse files Browse the repository at this point in the history
The HTTP API provides `PUT /v2/hosts/:id` endpoint instead of the currently configured `PUT /v1/hosts/:id`.
  • Loading branch information
janartodesk authored Oct 22, 2024
1 parent 4c924d3 commit 4e68bc1
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 2 deletions.
2 changes: 1 addition & 1 deletion internal/definednet/host.go
Original file line number Diff line number Diff line change
Expand Up @@ -70,7 +70,7 @@ type GetHostRequest struct {
// UpdateHost updates a Defined.net host.
func UpdateHost(ctx context.Context, client Client, req UpdateHostRequest) (*Host, error) {
var resp Response[Host]
if err := client.Do(ctx, http.MethodPut, []string{"v1", "hosts", req.ID}, req, &resp); err != nil {
if err := client.Do(ctx, http.MethodPut, []string{"v2", "hosts", req.ID}, req, &resp); err != nil {
return nil, err
}

Expand Down
2 changes: 1 addition & 1 deletion internal/definednet/host_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -99,7 +99,7 @@ var _ = Describe("getting hosts", func() {
var _ = Describe("updating hosts", func() {
Specify("hosts are updated on Defined.net", func(ctx SpecContext) {
server.AppendHandlers(ghttp.CombineHandlers(
ghttp.VerifyRequest(http.MethodPut, "/v1/hosts/host-id"),
ghttp.VerifyRequest(http.MethodPut, "/v2/hosts/host-id"),
ghttp.VerifyJSONRepresenting(map[string]any{
"roleID": "role-id",
"name": "host.smaily.testing",
Expand Down

0 comments on commit 4e68bc1

Please sign in to comment.