Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(feat): add option to enable debugging in compiled sketches #722

Open
wants to merge 5 commits into
base: master
Choose a base branch
from

Conversation

Thiemann96
Copy link
Contributor

@Thiemann96 Thiemann96 commented Feb 15, 2023

Option can be set by providing the parameter to the getSketch/script route

/boxes/6399ecf5a106c63060d6a350/script?appEUI=&appKey=&devEUI=&display_enabled=false&enable_debug=true&password=&serialPort=Serial1&soilDigitalPort=A&soundMeterPort=B&ssid=&windSpeedPort=C

Description

Motivation and Context

Eases support

How Has This Been Tested?

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code has been linted using yarn run lint.
  • My code does not break the tests (yarn run test)
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.

@mpfeil mpfeil self-requested a review March 13, 2023 17:20
Copy link
Member

@mpfeil mpfeil left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good. We just have to wait for the new release of sketch-templater which includes the new debug option.

sensebox/node-sketch-templater#134

Please update the version in package.json when the sketch-templater is released.

@mpfeil mpfeil added this to the v11.2.0 milestone Sep 7, 2023
@mpfeil mpfeil changed the title added option to enable debugging in compiled sketches (feat): add option to enable debugging in compiled sketches Sep 7, 2023
@mpfeil mpfeil removed this from the v11.2.0 milestone Oct 11, 2023
@mpfeil mpfeil added this to the v12.0.0 milestone Oct 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants