Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix --save_folder CLI Option #26

Merged
merged 4 commits into from
Jun 22, 2022
Merged

Fix --save_folder CLI Option #26

merged 4 commits into from
Jun 22, 2022

Conversation

vassilispapadop
Copy link
Contributor

Description

Fixes # #21

Changelog:

Updated:

  • dot/commons/model_option.generate_from_image(). Use ofos module for path concatenation.

@vassilispapadop vassilispapadop added the bug Something isn't working label Jun 22, 2022
@vassilispapadop vassilispapadop marked this pull request as ready for review June 22, 2022 08:24
@vassilispapadop vassilispapadop self-assigned this Jun 22, 2022
@ajndkr ajndkr changed the title Fix --save_folder CLI Option Fix --save_folder CLI Option Jun 22, 2022
ajndkr
ajndkr reviewed Jun 22, 2022
View reviewed changes
dot/commons/model_option.py Outdated Show resolved Hide resolved
@ajndkr ajndkr requested a review from ghassen1302 June 22, 2022 14:13
@ajndkr
Copy link
Member

ajndkr commented Jun 22, 2022

@Ghassen-Chaabouni can you review as well please?

@giorgiop giorgiop merged commit 2af0425 into main Jun 22, 2022
@giorgiop giorgiop deleted the bug/cli_option_save_folder branch June 22, 2022 15:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ajndkr ajndkr ajndkr left review comments

@giorgiop giorgiop giorgiop approved these changes

@ghassen1302 ghassen1302 ghassen1302 approved these changes

Assignees

@vassilispapadop vassilispapadop

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@vassilispapadop @ajndkr @giorgiop @ghassen1302 @Ghassen-Chaabouni