Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update check-elb-nodes for AWS-SDK v2 #246

Merged
merged 1 commit into from
Oct 16, 2017
Merged

Conversation

eheydrick
Copy link
Collaborator

Pull Request Checklist

Is this in reference to an existing issue?
#240

General

  • Update Changelog following the conventions laid out here

  • Update README with any necessary configuration snippets

  • Binstubs are created if needed

  • RuboCop passes

  • Existing tests pass

Purpose

Update for AWS-SDK v2. This improves performance and reliability and gets us closer to being able to remove support for v1.

OK state

$ ./check-elb-nodes.rb -n some-elb -r us-west-2
CheckELBNodes OK: InService: 2 (i-87a3d35a, i-a0c81534); OutOfService: 0; Unknown: 0

Warning state

$ ./check-elb-nodes.rb -n some-elb -r us-west-2 -w 1
CheckELBNodes WARNING: InService: 1 (i-87a3d35a); OutOfService: 1 (i-a0c81534); Unknown: 0

Known Compatibility Issues

This is a breaking change because it removes aws_access_key and aws_secret_access_key options per #2.

Copy link
Member

@majormoses majormoses left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@eheydrick eheydrick merged commit 49af2dd into master Oct 16, 2017
@eheydrick eheydrick deleted the aws_sdk_v2_elb_nodes branch October 25, 2017 06:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants