Highlight false positives in check-sqs-messages
when metric is unsupported
#381
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Checklist
#380
General
Update Changelog following the conventions laid out here
Update README with any necessary configuration snippets
Binstubs are created if needed
RuboCop passes
Existing tests pass
Purpose
Highlight false positives in
check-sqs-messages
when metric is unsupportedPreviously you could see something like this:
Instead this will now properly notify responders to the (now) known bug. As it appears to be an api limitation and not something we did in our code we will keep the discussion open for a proper solution but first things first is getting it to tell the truth. After the fix it should look something like this:
Signed-off-by: Ben Abrams me@benabrams.it
Known Compatibility Issues
There is a bug that is being masked, this surfaces it. This will not actually break any code, system, etc but deploying this will result in several
unknown
s from community members.