Update Add windows github action workflow #129
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
powershell is able to access path variables without additional configuration powershell_script - use code
derekgroh
added a commit
to derekgroh/sensu-go-chef
that referenced
this pull request
Nov 24, 2020
webframp
approved these changes
Nov 30, 2020
7 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Checklist
Is this in reference to an existing issue?
#68 and PR #123
General
Update Changelog following the conventions laid out here
Update README with any necessary configuration snippets
Cookstyle (rubocop) passes
fails on v7.2.1 as
ChefDeprecations/ChefSpecCoverageReporthas been renamed toChef/Deprecations/ChefSpecCoverageReport, but Chef Delivery will fail as it does not know the new name.Rspec (unit tests) passes
Inspec (integration tests) passes
New Features
Purpose
Creates CI/CD testing for the windows platforms using GitHub Actions.
Known Compatibility Issues
sensu_agentresource addedignore_failure trueas service start fails due to a noisy log. This isn't a great practice as the resource could still fail, but the failure is suppressed, however the Inspec tests should cover this case.sensu_ctlGitHub Actions does not support windows containers so the public instance of the sensu_backend is used to validate sensuctl being installed successfully. There might be a way to run a Linux sensu_backend and allow the windows image to connect to it instead.