-
Notifications
You must be signed in to change notification settings - Fork 177
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Updated etcd to 3.3.2 #1193
Updated etcd to 3.3.2 #1193
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
@jamesdphillips any idea why the Gopkg.lock file tends to stutter like this?
@echlebek it's likely due to differing versions of dep on each of our systems. I haven't found a great way to ensure we all have the same version of system-level go tools. |
If you're on a mac try running
As far as I'm concerned this is this is something |
I'm not on a mac but I think Mercedes is. I probably won't be installing dep with brew ;) |
Just updated dep - I was running a really old development version! Let me see if that has any effect on the lockfile. |
Turns out I was running a development version too. I followed the installation instructions and upgraded to 0.4.1. |
Autocompaction revision mode can now be set to an integer instead of a time-based value. Signed-off-by: Mercedes Coyle <mercedes@sensu.io>
a566b87
to
6ea4855
Compare
Updated dep put the lockfile back to the way it was 👍 |
What is this change?
Updates etcd to 3.3.2 so we can set autocompaction revision to an actual int instead of a time-based value.
Why is this change necessary?
Closes #1069
Does your change need a Changelog entry?
Added a note under Changed section.
Do you need clarification on anything?
Nope!
Were there any complications while making this change?
Nope!