Draft: Add OpenTelemetry #4345
Draft
Draft: Add OpenTelemetry #4345
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vooon
force-pushed
the
add-otel
branch
2 times, most recently
from
2709895
to
403c0be
Compare
Signed-off-by: Vladimir Ermakov <vooon341@gmail.com>
Signed-off-by: Vladimir Ermakov <vooon341@gmail.com>
Signed-off-by: Vladimir Ermakov <vooon341@gmail.com>
- add tracer to apid - add tracer to etcd store - add tracer to etcdstore v2 - add tracer to event_store - add tracers to schedulerd - add tracers to eventd - add tracers to cache - add tracer to health_store - add tracer to pipeline - add traces to ringv2 - add span to ringv2 hasTrigger Signed-off-by: Vladimir Ermakov <vooon341@gmail.com>
Signed-off-by: Vladimir Ermakov <vooon341@gmail.com>
Signed-off-by: Vladimir Ermakov <vooon341@gmail.com>
Signed-off-by: Vladimir Ermakov <vooon341@gmail.com>
|
Very interesting. I see the PR is in draft status, do you intend to work on it further? |
|
@echlebek yes, but i have two blokers for now:
|
|
@echlebek OTEL 1.0.0 have been released. But that'll still be a problem because etcd 3.6 far from release as i know. |
|
@echlebek etcd main now has fresh OTEL, so now i can rebase this PR. But i would have to replace etcd version. |
|
@fguimond in light of your recent spike work on open telemetry, do you think this PR can be partially incorporated? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is this change?
Adds distributed tracing with OpenTelemetry.
Why is this change necessary?
It's very handy tool to debug what's going on in your distributed service.
Does your change need a Changelog entry?
Yes.
Do you need clarification on anything?
Were there any complications while making this change?
Have you reviewed and updated the documentation for this change? Is new documentation required?
How did you verify this change?
Is this change a patch?
No.