Etcd cleanup #5065
Open
Etcd cleanup #5065
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: manisha kumari <manisha.kumari@calsoftinc.com>
Signed-off-by: manisha kumari <manisha.kumari@calsoftinc.com>
Signed-off-by: manisha kumari <manisha.kumari@calsoftinc.com>
Signed-off-by: manisha kumari <manisha.kumari@calsoftinc.com>
Signed-off-by: manisha kumari <manisha.kumari@calsoftinc.com>
Signed-off-by: manisha kumari <manisha.kumari@calsoftinc.com>
Signed-off-by: manisha kumari <manisha.kumari@calsoftinc.com>
Signed-off-by: manisha kumari <manisha.kumari@calsoftinc.com>
Signed-off-by: manisha kumari <manisha.kumari@calsoftinc.com>
Signed-off-by: manisha kumari <manisha.kumari@calsoftinc.com>
elfranne
reviewed
Sep 26, 2024
| if _, err := s.client.Put(ctx, userSessionPath(username, sessionID), state); err != nil { | ||
|
|
||
| leaseDuration := jwt.DefaultAccessTokenLifespan | ||
| ttl := int64(leaseDuration.Minutes()+1) * 60 |
There was a problem hiding this comment.
Any reason to adding a minute to the lease?
There was a problem hiding this comment.
This is to keep a buffer in deletion, no other reason.
fguimond
reviewed
Sep 26, 2024
CHANGELOG-6.md
Outdated
|
|
||
| ### Changed | ||
| - ADD TTL to each user session in the etcd data store to prevent leak. | ||
| - TTl value is DefaultAccessTokenLifeSpan + 1 minute |
There was a problem hiding this comment.
Just one comment per change is required. The second entry can be removed.
Signed-off-by: manisha kumari <manisha.kumari@calsoftinc.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closed #5063
Description
The user sessions gets piled up in etcd occupying upto 2bg space .
Change in behavior
Deleting the etcd user_sesssions them after 6 minutes of creation ( Access token of session gets expired in 5 mnts) This change will make sure the memory occupancy uptil 1.8 GB will be eradicated
Added
Added TTL time of 6 minutes in session.go file for each entry regarding user-sessions.
Fixed
This fixes the etcd space occupancy issue .
Change verification
Do sensuctl configure.
Check respective entry in etcd ar /sensu.io/user-sessions/admin/xxyyzz[session_id]
this entry will be deleted automatically after 11 minutes if the backend keep .
I have the video of default behaviour ( which caused the issue) and the video of fixed behaviour with TTL=2mins , unfortunately cannot be uploaded due to big size