-
Notifications
You must be signed in to change notification settings - Fork 21
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enhancement/pager teams #39
Conversation
reverted back to suffix... removed the short argument option for both team-name. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'd recommend making the naming more consistent between the flags and environment variables. For instance it's --pager-team
and PAGERDUTY_TEAM
, kind of makes it hard for people to remember. Other than that, looks good!
@echlebek fixed in newest commit |
This PR implements feature request: #38
Note:
using prefix instead of suffix as prefix works better with available single charactger shorthand cmdline arguments.
All logic constrained as part of checkArgs function
team token will be preferred over auth token if team token is available in matching environment variable.
Added initial test of new logic.
Will be adding more tests now.