Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enhancement/pager teams #39

Merged
merged 17 commits into from
Feb 25, 2021
Merged

Enhancement/pager teams #39

merged 17 commits into from
Feb 25, 2021

Conversation

jspaleta
Copy link
Contributor

@jspaleta jspaleta commented Feb 19, 2021

This PR implements feature request: #38

Note:
using prefix instead of suffix as prefix works better with available single charactger shorthand cmdline arguments.

All logic constrained as part of checkArgs function
team token will be preferred over auth token if team token is available in matching environment variable.

Added initial test of new logic.
Will be adding more tests now.

@jspaleta
Copy link
Contributor Author

reverted back to suffix... removed the short argument option for both team-name.
Which is fine.. most of the time you'll be using the team name from the annotation support.

Copy link
Contributor

@echlebek echlebek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd recommend making the naming more consistent between the flags and environment variables. For instance it's --pager-team and PAGERDUTY_TEAM, kind of makes it hard for people to remember. Other than that, looks good!

README.md Outdated Show resolved Hide resolved
@jspaleta
Copy link
Contributor Author

@echlebek fixed in newest commit

@jspaleta jspaleta merged commit c648e24 into main Feb 25, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants