support handlers that need to pass through mutated json #78
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In order to support mutated json passed into a handler, we need to disable eventRead and/or eventValidation.
Currently the SDK doesn't allow for this in the Handler concept.
This PR adds additional Handler functions to explicitly disable these plugin framework properties before handler Execute() is called.
Example handler use-case
building 'generic' webhook handlers to send json to arbitrary webhook url.
The payload needed by the receiving webhook would be mutated in the Sensu pipeline and will not longer be expected to be recognizable as a Sensu Event.
https://github.com/jspaleta/sensu-http-handler
This repo uses commits from this PR to disable event read so that arbitrary byte string on stdin can be passed to an external http endpoint