Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature/sensitive arguments as envvars #12

Merged
merged 4 commits into from
Jan 8, 2019
Merged

Feature/sensitive arguments as envvars #12

merged 4 commits into from
Jan 8, 2019

Conversation

jspaleta
Copy link
Contributor

@jspaleta jspaleta commented Jan 4, 2019

Treat webhook as sensitive, default to taking value from SLACK_WEBHOOK_URL envvar

@jspaleta jspaleta requested a review from nikkictl January 4, 2019 08:26
@jspaleta jspaleta force-pushed the feature/sensitive-arguments-as-envvars branch from 8db7ab9 to 6c65c14 Compare January 4, 2019 09:02
nikkictl
nikkictl suggested changes Jan 4, 2019
View reviewed changes
Copy link

@nikkictl nikkictl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same comments here as sensu-influxdb-handler:

  • update help usage in readme
  • call out environment variables in readme
  • need "Unreleased" changelog entry

Thanks for these improvements Jef, looking great so far!

@jspaleta
Copy link
Contributor Author

jspaleta commented Jan 5, 2019

requested changes added in latest commit

@jspaleta
Copy link
Contributor Author

jspaleta commented Jan 5, 2019

i'm doing some more testing locally to make sure this works.

@nikkictl nikkictl merged commit fd027a7 into sensu:master Jan 8, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nikkictl nikkictl nikkictl approved these changes

Assignees

@jspaleta jspaleta

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jspaleta @nikkictl @10xjs