Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

garbage collection worker to clean-up hanging jobs #2

Closed
senthilrch opened this issue Oct 26, 2018 · 1 comment
Closed

garbage collection worker to clean-up hanging jobs #2

senthilrch opened this issue Oct 26, 2018 · 1 comment
Assignees
Labels
done Code pushed to develop branch enhancement Enhancement to existing feature

Comments

@senthilrch
Copy link
Owner

if the imagepuller pod is unable to pull the image, it keeps retrying. The job that created the imagepuller pod has an activeDeadlineSeconds = 3600. so users can query the imagepuller pod's events to understand the reason for failure.

we need a garbage collection worker in image manager to cleanup jobs that have reached activeDeadlineSeconds.

@senthilrch senthilrch added enhancement Enhancement to existing feature done Code pushed to develop branch labels Oct 26, 2018
@senthilrch
Copy link
Owner Author

Implemented alternate solution. For jobs still active after image-pull-deadline-duration, image manager retrieves the events for the failed/running imagepuller pods and updates it to status of image cache. User can get the details of failure reason directly from image cache status "failures" section. Before updating status update work item to the work queue, image manager deletes all jobs (successful/pending) since they are no longer needed. Refer to following commit:-

654c075

@senthilrch senthilrch self-assigned this Oct 29, 2018
senthilrch added a commit that referenced this issue Jun 2, 2020
senthilrch added a commit that referenced this issue Jun 13, 2021
senthilrch added a commit that referenced this issue Oct 21, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
done Code pushed to develop branch enhancement Enhancement to existing feature
Projects
None yet
Development

No branches or pull requests

1 participant