Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix failing go test cases (#135)
What?
Test case 6: One dangling job. Successful list. Unsuccessful delete (TestPreFlightChecks) was failing with
panic: runtime error: invalid memory address or nil pointer dereference
Why?
danglingJobs() filters the jobList on the basis of following LabelSelector -
app=kubefledged,kubefledged=kubefledged-image-manager
but these Labels were not set in the test data.Solution
Passed the map with the above labels in the test data