Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Polish CRD manager/controller with the latest controller-runtime API #3

Merged
merged 5 commits into from
Jan 5, 2022
Merged

Polish CRD manager/controller with the latest controller-runtime API #3

merged 5 commits into from
Jan 5, 2022

Conversation

sczyh30
Copy link
Member

@sczyh30 sczyh30 commented Jan 4, 2022

  • Upgrade controller-gen version to v0.7.0 and polish Makefile (do not use trivialVersions)
  • Re-generate CRD files with apiextensions.k8s.io/v1 apiVersion
  • Update sentinel-golang to v1.0.3, controller-runtime to v0.9.7
  • Polish CRD manager/controller with the latest controller-runtime API

sczyh30 added 5 commits January 4, 2022 13:58
@sczyh30
Upgrade controller-gen version to v0.7.0 and polish Makefile
8d1feaa 
* Do not use trivialVersions

Signed-off-by: Eric Zhao <sczyh16@gmail.com>
@sczyh30
Update CRD definition (regenerate)
41e02cc 
Signed-off-by: Eric Zhao <sczyh16@gmail.com>
@sczyh30
Update sentinel-golang to v1.0.3, controller-runtime to v0.9.7
b2777c2 
Signed-off-by: Eric Zhao <sczyh16@gmail.com>
@sczyh30
Polish CRD manager/controller to adapt to the latest controller-runti…
79a2925 
…me API

Signed-off-by: Eric Zhao <sczyh16@gmail.com>
@sczyh30
Update README.md
4ca4ac7 
Signed-off-by: Eric Zhao <sczyh16@gmail.com>
@sczyh30 sczyh30 added the enhancement New feature or request label Jan 4, 2022
@sczyh30 sczyh30 requested review from louyuting and a team January 4, 2022 06:46
louyuting
louyuting approved these changes Jan 4, 2022
View reviewed changes
Copy link
Member

@louyuting louyuting left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@sczyh30 sczyh30 merged commit c13aa44 into main Jan 5, 2022
@sczyh30 sczyh30 deleted the polish-controller-runtime branch January 5, 2022 02:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@louyuting louyuting louyuting approved these changes

Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sczyh30 @louyuting