Add wait wrapper around Batch V1/V2 user action calls until the status changes #549
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
mlubej
commented
Nov 7, 2024
mlubej
commented
- Added a simple wrapper which first saves the old status before performing the action, then it repeatedly checks for a status update until the wait is over. if the status doesn't change, it logs a warning
- added also for Batch V2
- added mocked tests for both
mlubej
commented
Nov 7, 2024
sentinelhub/api/batch/process.py
Outdated
| @@ -29,6 +31,23 @@ | |||
| BatchCollectionType = Union[str, dict, "BatchCollection"] | |||
|
|
|||
|
|
|||
| def batch_user_action_wait_for_status_change(func: Callable) -> Callable: | |||
| @wraps(func) | |||
| def retrying_func(self: SentinelHubBatch, batch_request: BatchRequest) -> Json: | |||
There was a problem hiding this comment.
@zigaLuksic not sure about the self type here. It works for batch V1, but batch V2 in principle has a different class, which I don't import here, but mypy seems to be happy
added 2 commits
November 7, 2024 21:02
|
Closing in favor of sentinel-hub/eo-grow#360 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.